BUG: Ensure Windows choice returns int32#13695
Merged
mattip merged 1 commit intonumpy:masterfrom Jun 3, 2019
Merged
Conversation
7ee800c to
7a80918
Compare
eric-wieser
reviewed
Jun 1, 2019
numpy/random/mtrand.pyx
Outdated
Member
There was a problem hiding this comment.
np.int should be deprecated (we just haven't implemented np.__getattr__ yet), you should use int directly
57d263b to
1f6f39c
Compare
eric-wieser
reviewed
Jun 1, 2019
numpy/random/mtrand.pyx
Outdated
Member
There was a problem hiding this comment.
nit: trailing whitespace added here
Downcast from searchsorted on Windows to ensure int32 is returned closes numpy#9867
1f6f39c to
2dd6f04
Compare
Member
|
LGTM. Any additional reviews? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downcast from searchsorted on Windows to ensure int32 is returned
closes #9867