BUG: Fix bad error message in np.memmap #13311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This previously raisd `OSError: [Errno 22] Invalid argument` while trying to seek to byte -1 of the file. It now raises `ValueError: cannot mmap an empty file` The simple fix is not to write the file at all if we know it's already long enough. In future we could consider allowing memmap to do an extra write behind the scenes to ensure the fiel is not empty, but that seems out of scope. Fixes numpygh-12653
tylerjereddy
approved these changes
Apr 12, 2019
Contributor
tylerjereddy
left a comment
There was a problem hiding this comment.
The new unit test matches the case in the reported issue, and I double checked locally that the full ValueError matches the one from the the standard library mmap, which is hard to argue with. CI is all green with the fix & the patch diff on codecov is 100 % as well. Commit message typos not worth fixing.
Thanks Eric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This previously raisd
OSError: [Errno 22] Invalid argumentwhile trying to seek to byte -1 of the file.It now raises
ValueError: cannot mmap an empty fileThe simple fix is not to write the file at all if we know it's already long enough.
In future we could consider allowing memmap to do an extra write behind the scenes to ensure the fiel is not empty, but that seems out of scope.
Fixes gh-12653