TST: Install pickle5 for CI testing with python 3.6/7#12091
Merged
charris merged 3 commits intonumpy:masterfrom Oct 8, 2018
Merged
TST: Install pickle5 for CI testing with python 3.6/7#12091charris merged 3 commits intonumpy:masterfrom
charris merged 3 commits intonumpy:masterfrom
Conversation
tylerjereddy
reviewed
Oct 5, 2018
| # Upgrade to the latest pip. | ||
| - 'python -m pip install -U pip setuptools wheel' | ||
|
|
||
| - if [%INSTALL_PICKLE5%]==[1] echo pickle5 >> tools/ci/appveyor/requirements.txt |
Contributor
There was a problem hiding this comment.
I'm pretty sure our Appveyor webhook is now disabled in favor of Azure Pipelines for windows testing, so I'm not sure there's much value in modifying the appveyor yml file.
Member
There was a problem hiding this comment.
Appveyor is still used for building wheels, let's not deprecate it just yet.
Member
|
You should also modify the azure yml |
Contributor
Author
|
@mattip done, do not hesitate if there is anything else :) |
Member
|
Thanks @pierreglaser . |
Closed
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gathers the changes to the CI images/script needed to test correctly the contents of the PR #12011, that implements pickle protocol 5 for numpy arrays.
For python 3.6 and 3.7, using pickle protocol 5 is possible only thanks to the
pickle5module. As we enable the use ofpickle5in the aforementioned PR,, we install the pickle5 module in some setups involving python 3.6 and 3.7 in order to test those functionalities.Pinging @ogrisel and @mattip