Skip to content

MAINT: remove surviving, unused, list comprehension#11843

Merged
eric-wieser merged 3 commits intonumpy:masterfrom
jeffyancey:_polybase-code-cleanup
Sep 4, 2018
Merged

MAINT: remove surviving, unused, list comprehension#11843
eric-wieser merged 3 commits intonumpy:masterfrom
jeffyancey:_polybase-code-cleanup

Conversation

@jeffyancey
Copy link
Copy Markdown
Contributor

Issue #11842

This variable is never used, and shows signs of being leftover from a previous implementation.

This variable is never used, and shows signs of being leftover from a previous implementation.
@charris
Copy link
Copy Markdown
Member

charris commented Aug 31, 2018

@eric-wieser ping.

@charris
Copy link
Copy Markdown
Member

charris commented Aug 31, 2018

You should put Closes #11842. in the commit message so that the associated issue is closed if this is merged..

@jeffyancey
Copy link
Copy Markdown
Contributor Author

Ah, my mistake. thank you.

@eric-wieser eric-wieser merged commit fe3412f into numpy:master Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants