BUG: Fix Fortran kind detection for aarch64 & s390x.#11725
Merged
charris merged 1 commit intonumpy:masterfrom Aug 14, 2018
Merged
BUG: Fix Fortran kind detection for aarch64 & s390x.#11725charris merged 1 commit intonumpy:masterfrom
charris merged 1 commit intonumpy:masterfrom
Conversation
Contributor
Author
|
Also, cc @tylerjereddy because I'm unsure why this does not fail on Shippable? (Maybe because |
QuLogic
commented
Aug 13, 2018
| return 8 | ||
| machine = platform.machine().lower() | ||
| if machine.startswith('power') or machine.startswith('ppc64'): | ||
| if machine.startswith(('aarch64', 'power', 'ppc64', 's390x')): |
Contributor
Author
There was a problem hiding this comment.
Also, not sure if this should be a strict check for the new ones instead of startswith.
Member
There was a problem hiding this comment.
Probably more compiler dependent, I'd guess. Let's put this in and fix it up if problems ensue.
Member
|
Thanks @QuLogic . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3424 (comment) and #8659.