BUG: Revert use of console_scripts.#11718
Conversation
The changes introduced in numpy#10463 caused f2py to hang in somde circumstances. There is may a better fix than this, but until it is implemented it is better to undo the change. Closes numpy#11649.
| 'console_scripts': [ | ||
| 'f2py = numpy.f2py.__main__:main', | ||
| 'conv-template = numpy.distutils.conv_template:main', | ||
| 'from-template = numpy.distutils.from_template:main', |
There was a problem hiding this comment.
I think these last two lines can stay? Were conv-template and from-template on the path before?
I suppose the other way of looking at it is that these are awfully generic names to add to the user's path.
There was a problem hiding this comment.
They are only used during builds and, AFAICT, only other functions in numpy/distutils use them, so I don't see the need to include them in a bin directory or windows equivalent. Note that the names are also changed.
The reason there are two such functions is that f2py and numpy have their own separate template definitions. It would be nice if some day we only needed one :)
There was a problem hiding this comment.
Which is also probably sufficient reason to remove the main functions that were added in #10463 and just do a complete reversion, but those added functions are also harmless.
|
Note that we may still want entry point sometime in the future, but a couple of things need to be done when they are added.
|
The changes introduced in #10463 caused f2py to hang in somde
circumstances. There is may a better fix than this, but
until it is implemented it is better to undo the change.
Closes #11649.