MAINT: Simplify dimension-juggling in np.pad#11011
Merged
charris merged 2 commits intonumpy:masterfrom May 13, 2018
Merged
Conversation
… losing the dimension in the first place. `arr[:,:,0,:,:].reshape(arr.shape[:2] + (1,) + arr.shape[3:])` is much more readable as `arr[:,:,0:1,:,:]` (and easier for subclasses to handle)
This is safe, because the arguments are always base-class ndarrays, so `keepdims` is guaranteed to be supported
3096502 to
4bdcbab
Compare
This was referenced Apr 30, 2018
Member
|
Cannot claim to have verified all the changes, but they look to be a repetitive rewrite of some common boiler plate making better use of indexing, so I'm going to rely on the tests. Thanks |
This was referenced Jun 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file is pretty repetitive - this picks off some of the low-hanging fruit.