BUG: Fix problems with linalg.norm with ord=numpy.inf #10688
Closed
the-master-guy wants to merge 2 commits intonumpy:masterfrom
Closed
BUG: Fix problems with linalg.norm with ord=numpy.inf #10688the-master-guy wants to merge 2 commits intonumpy:masterfrom
the-master-guy wants to merge 2 commits intonumpy:masterfrom
Conversation
Moved it later in the function to check whether a valid axis has been specified.
eric-wieser
requested changes
Mar 18, 2018
Member
eric-wieser
left a comment
There was a problem hiding this comment.
The test currently fails.
Additionally, this does the wrong thing for inputs larger than 1d, or for the keepdims argument.
I think this would be better implemented via #10635.
Member
|
@hameerabbasi: want to take this on using |
Contributor
|
@eric-wieser On it. 😀 |
Member
|
Closing in favor of #10992 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Placed the fix in a location so that other edge cases are not incorrect, and added a test to check for the specific edge case.
Closes #10655