-
-
Notifications
You must be signed in to change notification settings - Fork 12.2k
MAINT: Clarify alignment in DLPack #20338
Copy link
Copy link
Closed
Milestone
Description
The DLpack code currently has this comment:
/*
* Note: the `dlpack.h` header suggests/standardizes that `data` must be
* 256-byte aligned. We ignore this intentionally, because `__dlpack__`
* standardizes that `byte_offset` must be 0 (for now) to not break pytorch:
* https://github.com/data-apis/array-api/issues/293#issuecomment-964111413
*
* We further assume that exporting fully unaligned data is OK even without
* `byte_offset` since the standard does not reject it.
* Presumably, pytorch will support importing `byte_offset != 0` and NumPy
* can choose to use it starting about 2023. At that point, it may be
* that NumPy MUST use `byte_offset` to adhere to the standard (as
* specified in the header)!
*/
It seems entirely possible that what NumPy should do changes sooner or later. This should either be reviewed or updated according to whatever is decided for dlpack.h and/or __dlpack__.
Marked as milestone, since this should – by my current understanding – be reviewed around 2023.
Reactions are currently unavailable