-
-
Notifications
You must be signed in to change notification settings - Fork 12.2k
Broken bool supports in NumPy's percentile #19154
Copy link
Copy link
Closed
Labels
06 - RegressiontriagedIssue/PR that was discussed in a triage meetingIssue/PR that was discussed in a triage meeting
Description
#16273 (comment) broke the case of percentile with bools which causes to break pandas pandas' quantile too:
import pandas as pd
pd.DataFrame({"i": [0, 1, 2], "b": [False, False, True], "s": ["x", "y", "z"]}).quantile(q=0.5, numeric_only=True)Before
i 1.0
b 0.0
Name: 0.5, dtype: float64
After
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/.../python3.8/site-packages/pandas/core/frame.py", line 9266, in quantile
result = data._mgr.quantile(
File "/.../python3.8/site-packages/pandas/core/internals/managers.py", line 491, in quantile
block = b.quantile(axis=axis, qs=qs, interpolation=interpolation)
File "/.../python3.8/site-packages/pandas/core/internals/blocks.py", line 1592, in quantile
result = nanpercentile(
File "/.../python3.8/site-packages/pandas/core/nanops.py", line 1675, in nanpercentile
return np.percentile(values, q, axis=axis, interpolation=interpolation)
File "<__array_function__ internals>", line 5, in percentile
File "/.../python3.8/site-packages/numpy/lib/function_base.py", line 3818, in percentile
return _quantile_unchecked(
File "/.../python3.8/site-packages/numpy/lib/function_base.py", line 3937, in _quantile_unchecked
r, k = _ureduce(a, func=_quantile_ureduce_func, q=q, axis=axis, out=out,
File "/.../python3.8/site-packages/numpy/lib/function_base.py", line 3515, in _ureduce
r = func(a, **kwargs)
File "/.../python3.8/site-packages/numpy/lib/function_base.py", line 4064, in _quantile_ureduce_func
r = _lerp(x_below, x_above, weights_above, out=out)
File "/.../python3.8/site-packages/numpy/lib/function_base.py", line 3961, in _lerp
diff_b_a = subtract(b, a)
TypeError: numpy boolean subtract, the `-` operator, is not supported, use the bitwise_xor, the `^` operator, or the logical_xor function instead.
Reproducing code example:
import numpy as np
np.percentile([True, False, False], q=0.5)Error message:
Before (NumPy 1.19)
0.0
After
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "<__array_function__ internals>", line 5, in percentile
File "/.../python3.8/site-packages/numpy/lib/function_base.py", line 3818, in percentile
return _quantile_unchecked(
File "/.../python3.8/site-packages/numpy/lib/function_base.py", line 3937, in _quantile_unchecked
r, k = _ureduce(a, func=_quantile_ureduce_func, q=q, axis=axis, out=out,
File "/.../python3.8/site-packages/numpy/lib/function_base.py", line 3515, in _ureduce
r = func(a, **kwargs)
File "/.../python3.8/site-packages/numpy/lib/function_base.py", line 4064, in _quantile_ureduce_func
r = _lerp(x_below, x_above, weights_above, out=out)
File "/.../python3.8/site-packages/numpy/lib/function_base.py", line 3961, in _lerp
diff_b_a = subtract(b, a)
TypeError: numpy boolean subtract, the `-` operator, is not supported, use the bitwise_xor, the `^` operator, or the logical_xor function instead.
NumPy/Python version information:
1.20.3 3.8.8 (default, Apr 13 2021, 12:59:45)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
06 - RegressiontriagedIssue/PR that was discussed in a triage meetingIssue/PR that was discussed in a triage meeting