This repository was archived by the owner on Jan 9, 2018. It is now read-only.
Add support for CSV headers and fix parsing of numbers #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it's little bit far-fetched but in waiting (I'm using flatten and lodash too) : var flat = _.map(contacts, function(item){
return flatten(item);
});
var keys = _.reduce(_.keys(flat[0]), function(result, item){
result[item] = item;
return result;
}, {});
res.csv([keys].concat(flat));I hope this code help someone... ;-) |
Utilize iconv-lite to handle cyrillic data
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses one bug and introduces one feature. As with a few other pending pull requests, this introduces the ability to add headers to the CSV output by adding a boolean parameter to
res.csv. I have been using this in production for a few months now with no issues.Additionally, this pull request adds a check to
escapeto make sure that numbers are properly parsed as such, and are not surrounded by quotes in the output. This has proven useful, as it increases the likelihood that an application like Excel will properly recognize the data type of a field (i.e. numbers are numbers, and not strings).Thanks!