Skip to content

test(service): tighten systemctl status parsing#46

Merged
DonPrus merged 3 commits into
nullclaw:mainfrom
vernonstinebaker:test/service-boundaries
May 6, 2026
Merged

test(service): tighten systemctl status parsing#46
DonPrus merged 3 commits into
nullclaw:mainfrom
vernonstinebaker:test/service-boundaries

Conversation

@vernonstinebaker

Copy link
Copy Markdown
Contributor

Summary

  • tighten systemctl availability detection so generic "not found" text does not misclassify missing service units as a missing systemctl binary
  • add focused regression coverage for missing-command detection and systemd user-session detection helpers
  • keep the change isolated to service status parsing so API behavior remains stable while error classification becomes more accurate

Validation

  • zig build test -Dembed-ui=false -Dbuild-ui=false --summary all
  • npm --prefix ui ci --no-audit --no-fund
  • npm --prefix ui run build
  • bash tests/test_e2e.sh
  • zig fmt --check src/
  • git diff --check

Notes

  • this is intentionally a boundary-only slice: it protects the helper logic that decides whether to report "systemctl unavailable" versus a normal command failure
  • a typical missing-unit response like Unit nullhub.service could not be found. should no longer be treated as if the systemctl executable itself is absent

@DonPrus DonPrus merged commit 7e53ef9 into nullclaw:main May 6, 2026
4 checks passed
@vernonstinebaker vernonstinebaker deleted the test/service-boundaries branch May 6, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants