Skip to content

Add Irys Arweave bundler usage to taco-demo#503

Merged
piotr-roslaniec merged 2 commits into
nucypher:mainfrom
piotr-roslaniec:irys
Apr 15, 2024
Merged

Add Irys Arweave bundler usage to taco-demo#503
piotr-roslaniec merged 2 commits into
nucypher:mainfrom
piotr-roslaniec:irys

Conversation

@piotr-roslaniec

@piotr-roslaniec piotr-roslaniec commented Mar 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Type of PR:

  • Other

Required reviews:

  • 1

What this does:

  • Stores message encrypted during taco-demo on a free Irys node

Notes for reviewers:

  • Do we want to add integration examples with third parties to the repo? Should we contact them first? Does this count as an endorsement?
  • Should we document this further in our GitBook docs?
  • Should we create a separate demo for Irys rather than modifying the existing taco-demo?
  • Merging blocked because Irys depends on Mumbai - To be resolved before merging

@netlify

netlify Bot commented Mar 27, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for taco-demo ready!

Name Link
🔨 Latest commit 209c656
🔍 Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/661d3c490c860e00084d4649
😎 Deploy Preview https://deploy-preview-503--taco-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Mar 27, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for taco-nft-demo canceled.

Name Link
🔨 Latest commit 209c656
🔍 Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/661d3c4958bb37000863fe67

@theref theref self-requested a review March 27, 2024 11:57
@codecov-commenter

codecov-commenter commented Mar 27, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.29%. Comparing base (811cced) to head (9559274).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #503   +/-   ##
=======================================
  Coverage   23.29%   23.29%           
=======================================
  Files          63       63           
  Lines       10197    10197           
  Branches      261      261           
=======================================
  Hits         2375     2375           
  Misses       7763     7763           
  Partials       59       59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review April 2, 2024 18:19
manumonti
manumonti approved these changes Apr 5, 2024
View reviewed changes

@manumonti manumonti left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌

I really like the way in which this demo actually upload the encrypted data to a decentralized storage solution. This demo is very complete now.

derekpierre
derekpierre reviewed Apr 5, 2024
View reviewed changes
Comment thread demos/taco-demo/README.md Outdated
The current release of `@nucypher/taco` supports Ursulas working on Lynx (bleeding-edge) test
network and contracts deployed on Mumbai testnet.
The current release of `@nucypher/taco` supports Ursulas working on Lynx
(bleeding-edge) test network and contracts deployed on Mumbai testnet.

@derekpierre derekpierre Apr 5, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(bleeding-edge) test network and contracts deployed on Mumbai testnet.
(bleeding-edge) test network and contracts deployed on Polygon Amoy testnet.

@derekpierre derekpierre Apr 5, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have asked, is this demo for Tapir or Lynx or either?

@piotr-roslaniec piotr-roslaniec Apr 5, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either, as long as they both use Mumbai. Which is currently tricky because we transitioned to Amoy. I will document this in the PR description.

@piotr-roslaniec piotr-roslaniec added the blocked The progress on this issue is blocked for some reason label Apr 5, 2024
@piotr-roslaniec

piotr-roslaniec commented Apr 15, 2024

Copy link
Copy Markdown
Contributor Author

Rebased on top of main and updated Irys after their migration to Polygon Amoy

@piotr-roslaniec piotr-roslaniec merged commit f32b4f9 into nucypher:main Apr 15, 2024
@piotr-roslaniec piotr-roslaniec deleted the irys branch April 15, 2024 14:49
@arjunhassard arjunhassard mentioned this pull request Apr 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derekpierre derekpierre derekpierre left review comments
@theref theref theref approved these changes
@arjunhassard arjunhassard Awaiting requested review from arjunhassard
@KPrasch KPrasch Awaiting requested review from KPrasch
@cygnusv cygnusv Awaiting requested review from cygnusv
+1 more reviewer
@manumonti manumonti manumonti approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

blocked The progress on this issue is blocked for some reason

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@piotr-roslaniec @codecov-commenter @theref @derekpierre @manumonti