[WIP] Full circle of Ursula's Identity evidence#996
[WIP] Full circle of Ursula's Identity evidence#996cygnusv wants to merge 10 commits intonucypher:masterfrom
Conversation
…ith stamp substantiation
Codecov Report
@@ Coverage Diff @@
## master #996 +/- ##
==========================================
+ Coverage 84.98% 85.01% +0.02%
==========================================
Files 65 65
Lines 7908 7921 +13
==========================================
+ Hits 6721 6734 +13
Misses 1187 1187
Continue to review full report at Codecov.
|
| // TODO: This will depend on the outcome of #962 | ||
| address miner = SignatureVerifier.recover( | ||
| SignatureVerifier.hash(_minerPublicKey, hashAlgorithm), _minerPublicKeySignature); | ||
| SignatureVerifier.hash(abi.encodePacked(precomp.lostBytes[4], miner_xcoord), |
There was a problem hiding this comment.
See
BTW, there's a typo in the linked comment, and it should be 4 where it says 5. I'll correct it.
| SignatureVerifier.HashAlgorithm.KECCAK256), | ||
| _minerPublicKeySignature); | ||
| // Check that miner can be slashed | ||
| (uint256 minerValue,,,,,) = escrow.minerInfo(miner); |
There was a problem hiding this comment.
Is this the only way to know that the miner can be slashed?
There was a problem hiding this comment.
AFAIK, what this actually checks is that the miner is registered by MinersEscrow. @szotov is that right?
There was a problem hiding this comment.
And also that miner has something that we can take: miner can be slashed if he has stake,
in #949 this line was changed to getAllTokens
nucypher/characters/lawful.py
Outdated
| ursula = self.known_nodes[node_id] | ||
| for ursula_checksum_address, arrangement_id in treasure_map_to_use: | ||
| ursula = self.known_nodes[ursula_checksum_address] | ||
| assert ursula.checksum_public_address == ursula_checksum_address |
There was a problem hiding this comment.
Production assert? This will be the third one. Perhaps a comment will help.
There was a problem hiding this comment.
Oops! My bad, I was just checking something and I forgot about it.
|
Closed. Will try again as part of Alhambra Verde EPIC (#1029) |
This PR closes the gap between learning about Ursulas and requesting a slashing to one of them, in particular wrt to Ursula's identity evidence (#962).