Skip to content

Integrate Auto-IP Detection and Default Keyring Account#980

Merged
KPrasch merged 5 commits intonucypher:hawksbeardfrom
KPrasch:hawksbeard
May 16, 2019
Merged

Integrate Auto-IP Detection and Default Keyring Account#980
KPrasch merged 5 commits intonucypher:hawksbeardfrom
KPrasch:hawksbeard

Conversation

@KPrasch
Copy link
Member

@KPrasch KPrasch commented May 16, 2019

No description provided.

@KPrasch KPrasch changed the title Hawksbeard Integrate Auto-IP Detection and Default Keyring Account May 16, 2019
checksum_address = self.checksum_public_address

# Generate a federated checksum address
elif self.federated_only and not self.checksum_public_address:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #980 into hawksbeard will increase coverage by 2.44%.
The diff coverage is 50%.

Impacted file tree graph

@@              Coverage Diff               @@
##           hawksbeard     #980      +/-   ##
==============================================
+ Coverage       79.84%   82.28%   +2.44%     
==============================================
  Files              67       67              
  Lines            8538     8541       +3     
==============================================
+ Hits             6817     7028     +211     
+ Misses           1721     1513     -208
Impacted Files Coverage Δ
nucypher/blockchain/eth/registry.py 63.75% <ø> (ø) ⬆️
nucypher/config/node.py 79% <25%> (+0.29%) ⬆️
nucypher/cli/characters/ursula.py 68.98% <30%> (+7.74%) ⬆️
nucypher/cli/actions.py 63.95% <60.71%> (+13.95%) ⬆️
nucypher/network/nodes.py 82.54% <0%> (+0.32%) ⬆️
nucypher/config/storages.py 76.2% <0%> (+0.6%) ⬆️
nucypher/cli/main.py 90.32% <0%> (+1.61%) ⬆️
nucypher/config/keyring.py 89.68% <0%> (+2.18%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d777ffa...4cb0ded. Read the comment docs.

@KPrasch KPrasch marked this pull request as ready for review May 16, 2019 03:25
@KPrasch KPrasch merged commit fcaac88 into nucypher:hawksbeard May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants