(Almost) Passing Felix Tests - Operational Decentralized Distribution#969
Merged
KPrasch merged 24 commits intonucypher:hawksbeardfrom May 15, 2019
Merged
(Almost) Passing Felix Tests - Operational Decentralized Distribution#969KPrasch merged 24 commits intonucypher:hawksbeardfrom
KPrasch merged 24 commits intonucypher:hawksbeardfrom
Conversation
…ain init to dev-only processes
…mtn; Begin the movement to integrate BlockchainPower.
derekpierre
reviewed
May 14, 2019
derekpierre
reviewed
May 14, 2019
derekpierre
reviewed
May 15, 2019
derekpierre
reviewed
May 15, 2019
| if self.provider_process: | ||
|
|
||
| if not os.path.exists(self.provider_process.data_dir): | ||
| os.mkdir(self.provider_process.data_dir) |
Member
Author
There was a problem hiding this comment.
Hmm - Yeah explicit is better than implicit?
cygnusv
reviewed
May 15, 2019
Member
cygnusv
left a comment
There was a problem hiding this comment.
Just a few comments. Also, how can I try this?
Member
Author
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR goes into EPIC #951
Opens Issues: #976 #975 #974 #973