Skip to content

Publish Porter docker image#2733

Merged
derekpierre merged 3 commits intonucypher:porterfrom
derekpierre:porter-publish
Jul 5, 2021
Merged

Publish Porter docker image#2733
derekpierre merged 3 commits intonucypher:porterfrom
derekpierre:porter-publish

Conversation

@derekpierre
Copy link
Copy Markdown
Member

@derekpierre derekpierre commented Jul 2, 2021

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

Based over #2732 .

Issues fixed/closed:
Related to #2669 , #2724 .

Why it's needed:
We need to publish a docker image for porter specifically.

Notes for reviewers:

@derekpierre derekpierre added this to the Porter v1 (MVP) milestone Jul 2, 2021
@derekpierre derekpierre requested a review from cygnusv July 2, 2021 00:14
@derekpierre derekpierre self-assigned this Jul 2, 2021
@derekpierre derekpierre requested review from KPrasch and vepkenez July 2, 2021 16:09
@derekpierre derekpierre changed the title [WIP] Publish Porter docker image Publish Porter docker image Jul 2, 2021
@derekpierre derekpierre marked this pull request as ready for review July 2, 2021 16:56
Copy link
Copy Markdown
Member

@KPrasch KPrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Left one comment about naming.

Minor cleanups including docker-compose container names, and documentation updates.
…orter.

Update documentation regarding the port that the Porter service runs on.
porter-http:
restart: on-failure
image: nucypher:latest
image: porter:latest
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good

@derekpierre derekpierre merged commit 2755f9e into nucypher:porter Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants