Skip to content

Allow Porter to launch with TLS#2720

Merged
derekpierre merged 3 commits intonucypher:porterfrom
derekpierre:ssh-its-a-secret
Jun 21, 2021
Merged

Allow Porter to launch with TLS#2720
derekpierre merged 3 commits intonucypher:porterfrom
derekpierre:ssh-its-a-secret

Conversation

@derekpierre
Copy link
Copy Markdown
Member

@derekpierre derekpierre commented Jun 9, 2021 •
edited
Loading

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:
Based over #2717 (which should be reviewed first).

--tls-key-filepath and --certificate-filepath options can now be provided to nucypher porter run ... for Porter to be launched with TLS i.e. https.

For testing you can create a tls key and certificate for the localhost using the openssl command:

openssl req -x509 -out fullchain.pem -keyout key.pem \
  -newkey rsa:2048 -nodes -sha256 \
  -subj '/CN=localhost' -extensions EXT -config <( \
   printf "[dn]\nCN=localhost\n[req]\ndistinguished_name = dn\n[EXT]\nsubjectAltName=DNS:localhost\nkeyUsage=digitalSignature\nextendedKeyUsage=serverAuth")

@derekpierre derekpierre added Security Security concern Web Webpages labels Jun 9, 2021
@derekpierre derekpierre added this to the Porter v1 (MVP) milestone Jun 9, 2021
@derekpierre derekpierre self-assigned this Jun 9, 2021
@derekpierre derekpierre changed the title [WIP] Allow Porter to launch with TLS Allow Porter to launch with TLS Jun 10, 2021
@derekpierre derekpierre marked this pull request as ready for review June 10, 2021 13:09
@derekpierre derekpierre mentioned this pull request Jun 10, 2021
Merged
@derekpierre derekpierre force-pushed the ssh-its-a-secret branch 3 times, most recently from 898bb5a to e872fb1 Compare June 14, 2021 20:18
@derekpierre derekpierre mentioned this pull request Jun 16, 2021
Merged
7 tasks
KPrasch
KPrasch reviewed Jun 18, 2021
View reviewed changes
KPrasch
KPrasch approved these changes Jun 18, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@KPrasch KPrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤠

@derekpierre derekpierre merged commit fb2d8c1 into nucypher:porter Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KPrasch KPrasch KPrasch approved these changes

@fjarri fjarri Awaiting requested review from fjarri

@jMyles jMyles Awaiting requested review from jMyles

@cygnusv cygnusv Awaiting requested review from cygnusv

@vepkenez vepkenez Awaiting requested review from vepkenez

+1 more reviewer

@piotr-roslaniec piotr-roslaniec piotr-roslaniec approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@derekpierre derekpierre

Labels

Security Security concern Web Webpages

Projects

None yet

Milestone

Porter v1 (MVP)

Development

Successfully merging this pull request may close these issues.

3 participants

@derekpierre @KPrasch @piotr-roslaniec