[WIP] My first batch of TreasureMaps con KFrags#2530
Closed
cygnusv wants to merge 26 commits intonucypher:mainfrom
Closed
[WIP] My first batch of TreasureMaps con KFrags#2530cygnusv wants to merge 26 commits intonucypher:mainfrom
cygnusv wants to merge 26 commits intonucypher:mainfrom
Conversation
fjarri
reviewed
Jan 18, 2021
fjarri
reviewed
Jan 18, 2021
nucypher/policy/collections.py
Outdated
| public_signature: Signature = None, | ||
| hrac: Optional[bytes] = None) -> None: | ||
| hrac: Optional[bytes] = None, | ||
| version: bytes = None) -> None: |
Contributor
There was a problem hiding this comment.
In what cases would we want to specify the version externally? A version determines how an object is serialized to bytes, which is hardcoded into the class definition.
fjarri
reviewed
Jan 18, 2021
nucypher/policy/collections.py
Outdated
|
|
||
| class TreasureMap: | ||
| ID_LENGTH = 32 | ||
| version = bytes.fromhex("42") # FIXME: This is a placeholder versioning, while we devise a better data serialization format |
Contributor
There was a problem hiding this comment.
Does that mean we're going the way of having versioned classes instead of a versioned protocol? I guess it provides more flexibility, but there might be problems with processing nested classes, each with its own version.
Member
Author
There was a problem hiding this comment.
As hinted in the comment, this is just a temporary scheme to facilitate some versioning, reusing the existing serialization approach; it's not intended to be definitive.
bd929d3 to
151811a
Compare
vepkenez
reviewed
Jan 21, 2021
| return Response(b"This will eventually be an actual acceptance of the arrangement.", headers=headers) | ||
|
|
||
| @rest_app.route("/kFrag/<id_as_hex>", methods=['POST']) | ||
| def set_policy(id_as_hex): |
7 tasks
8 tasks
e66bc3d to
56d692e
Compare
This was referenced Mar 30, 2021
ab76a30 to
94bbf53
Compare
We will transition to a better serialization approach (e.g., protobuf) so versioning is simpler to manage
Updated both server and client sides.
…y used in Ursula's side to get the Kfrag from the re-encryption request
Careful, don't scare the unit tests...
…dling of publisher/authorizer keys.
…ove publication transaction from policy method signatures.
…ve method of verifying payment, deprecates usage of txhash completely.
94bbf53 to
9eb463a
Compare
Member
|
Replaced by #2687 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed in favor of #2687.
This PR is mainly intended as an approximation of how to introduce "TreasureMaps con KFrags"
Issues to address here:
Other issues that can potentially fit here: