Skip to content

[WIP] CLI demo#1424

Closed
cygnusv wants to merge 20 commits intonucypher:masterfrom
cygnusv:cli-demo
Closed

[WIP] CLI demo#1424
cygnusv wants to merge 20 commits intonucypher:masterfrom
cygnusv:cli-demo

Conversation

@cygnusv
Copy link
Copy Markdown
Member

@cygnusv cygnusv commented Oct 19, 2019

  • Added support for --rate

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 19, 2019 •
edited
Loading

Codecov Report

Merging #1424 into master will decrease coverage by 21.72%.
The diff coverage is 10%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1424       +/-   ##
===========================================
- Coverage   84.36%   62.63%   -21.73%     
===========================================
  Files          72       72               
  Lines       11226    11263       +37     
===========================================
- Hits         9471     7055     -2416     
- Misses       1755     4208     +2453
Impacted Files Coverage Δ
nucypher/characters/control/interfaces.py 93.51% <ø> (-2.78%) ⬇️
nucypher/characters/control/serializers.py 83.87% <ø> (-2.42%) ⬇️
nucypher/network/nodes.py 78.43% <ø> (-2.12%) ⬇️
nucypher/cli/characters/alice.py 0% <0%> (-84.22%) ⬇️
nucypher/cli/characters/bob.py 0% <0%> (-89.17%) ⬇️
nucypher/cli/types.py 0% <0%> (-78.27%) ⬇️
nucypher/cli/characters/enrico.py 0% <0%> (-90.7%) ⬇️
nucypher/blockchain/eth/actors.py 67.32% <100%> (-20.22%) ⬇️
nucypher/blockchain/eth/agents.py 64.64% <11.11%> (-26.51%) ⬇️
nucypher/policy/policies.py 86.91% <50%> (-1.68%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99d60b...e4df203. Read the comment docs.

michwill
michwill reviewed Oct 19, 2019
View reviewed changes
nucypher/blockchain/eth/agents.py Outdated
yield staker_address

def sample(self, quantity: int, duration: int, additional_ursulas: float = 1.7, attempts: int = 5) -> List[str]:
def sample(self, quantity: int, duration: int, additional_ursulas: float = 1.5, attempts: int = 5) -> List[str]:
Copy link
Copy Markdown
Contributor

@michwill michwill Oct 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... I thought, more additional Ursulas would perform better?

@cygnusv cygnusv force-pushed the cli-demo branch 5 times, most recently from 5fcd8a8 to 4549529 Compare October 23, 2019 11:52
@cygnusv cygnusv changed the title [WIP] Bugfixes for granting [WIP] CLI demo Oct 23, 2019
@cygnusv cygnusv force-pushed the cli-demo branch 9 times, most recently from b16096d to d0e27ba Compare October 25, 2019 11:09
@cygnusv cygnusv force-pushed the cli-demo branch 12 times, most recently from 1965e4a to 42dff00 Compare November 8, 2019 09:44
@cygnusv cygnusv force-pushed the cli-demo branch 2 times, most recently from 9b771af to ce67a49 Compare November 21, 2019 21:29
cygnusv added 20 commits November 27, 2019 00:54
@cygnusv
Added support to rate in Alice interface and serializers
c85c631
@cygnusv
Increase Learning timeout when sampling.
b449b64
@cygnusv
Janitorial stuff
e95dc80
@cygnusv
Define new click types for hex strings and public keys as hex
5e8b000
@cygnusv
Rough first pass at Bob CLI demo running on testnet. Include it in CI
8b2e90f
@cygnusv
Incorporate Enrico in CLI demo script. Make script slightly more elegant
0cd115b
@cygnusv
Save CLI demo logs and intermediate data as CI artifacts
6d7fee2
@cygnusv
When --json-ipc, get Alice's ETH password from NUCYPHER_ALICE_ETH_PAS…
fac546a 
…SWORD envvar
@cygnusv
Added some debug log messages wrt to sampling pagination to StakingEs…
42a3a5d 
…crowAgent
@cygnusv
Refactored --light flag; now it can be turned on/off for each command
1482cb9
@cygnusv
CI: Sync a goerli node as part of our nightly build. Cache chaindata
7f997c0
@cygnusv
Some CI cache magic to reuse geth chain data effectively
c8b3469
@cygnusv
CI: add static nodes to our goerli geth node
464a7e6
@cygnusv
CI: New geth cache after goerli istanbul fork
3074032
@cygnusv
First pass at a full CLI demo in CI: grant, encrypt and retrieve
3cc1147
@cygnusv
Use a toml file to define geth config
3447f82
@cygnusv
Dynamic pagination size for sampling (à la TCP slow start)
47b6354
@cygnusv
Touchups to CLI demo scripts
b753afd
@cygnusv
fasterrrrrrr
a51eb68
@cygnusv
Simplify dynamic pagination size: just retry once when size=1 fails
e4df203
@cygnusv cygnusv closed this Jan 26, 2020
@derekpierre derekpierre mentioned this pull request Jun 30, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@michwill michwill michwill left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cygnusv @michwill