[WIP] NuCypher ConnectNative Firefox Extension by vepkenez · Pull Request #1299 · nucypher/nucypher

vepkenez · 2019-09-05T16:48:26Z

extracted from Demo and rebased on master
An install script!
A readme!
Status check to tell you if it's installed correctly

requires #1555

codecov · 2019-09-05T17:23:12Z

Codecov Report

❗ No coverage uploaded for pull request base (birdcage@f593b74). Click here to learn what that means.
The diff coverage is 39.02%.

@@             Coverage Diff             @@
##             birdcage    #1299   +/-   ##
===========================================
  Coverage            ?   82.56%           
===========================================
  Files               ?       73           
  Lines               ?    10579           
  Branches            ?        0           
===========================================
  Hits                ?     8735           
  Misses              ?     1844           
  Partials            ?        0

Impacted Files	Coverage Δ
nucypher/network/teachers.py	`100% <ø> (ø)`
nucypher/cli/stdio.py	`0% <0%> (ø)`
nucypher/cli/characters/enrico.py	`75% <100%> (ø)`
nucypher/characters/control/specifications.py	`93.22% <100%> (ø)`
nucypher/cli/characters/alice.py	`73.18% <100%> (ø)`
nucypher/cli/characters/bob.py	`71.11% <100%> (ø)`
nucypher/cli/actions.py	`76.27% <94.73%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f593b74...db48bac. Read the comment docs.

tuxxy · 2019-09-18T09:34:28Z

What's the status of this PR? What do we need to get it merged?

michwill · 2019-09-28T08:08:18Z

Looks like putting a required value argument breaks (currently federated) character tests, as well as RPC API applied to federated network.
I've started working on a PR which allows optional arguments in the specs #1366. Perhaps, that's the way to solve. But since this problem was encountered and worked around here, I need to reference!

michwill · 2019-09-29T00:49:10Z

Well, actually I'm wrong. It works with RPC in general, just some bugs with web RPC in tests

michwill · 2019-09-29T07:07:41Z

Ok, looks like tests for optional arguments work properly in #1366. I think, if this PR will be rebased on top of that (will need to replace the specs), the character tests will pass

KPrasch · 2019-10-01T17:17:20Z

Awaiting PR #1366

KPrasch · 2019-10-02T00:31:46Z

Merged - Rebase needed.

michwill · 2019-10-02T23:29:41Z

I wonder if rebase will fix the tests, or some touches are required

vepkenez · 2019-10-03T00:22:22Z

rebased. lets see.

vepkenez · 2019-10-03T00:24:10Z

also what is "birdcage"?

michwill · 2019-10-03T00:34:01Z

Character tests pass!

vepkenez · 2019-10-03T00:35:22Z

I think this should probably be based over master?

michwill · 2019-10-03T00:36:23Z

The necessary change with optional arguments is already in master, yes

vepkenez · 2019-10-03T00:37:04Z

Yeah, that reduced the "files changed" from ~72 to 16

vepkenez · 2019-10-04T01:25:48Z

Ok this PR needs some tests. Some things aren't working for some reason so I'm going to put a [WIP] on it and finish writing tests around --options.

…ersionConflict pypa/pip#4537 (comment)

KPrasch · 2019-11-14T06:14:54Z

Installation scripts work, however it looks like the --options flag didn't make it into the codebase, leading to result: Usage: nucypher-cli status [OPTIONS] ACTION Try "nucypher-cli status --help" for help. Error: no such option: --options

vepkenez · 2019-11-14T17:32:00Z

@KPrasch yes I think the major CLI refactor which happened after this was all done is necessitating some re-working of this.

tuxxy · 2019-11-14T18:06:16Z

apps/connectnative/install/firefox.py

+    this_os = platform.system()
+    home = expanduser("~")
+
+    stdio_cli = shutil.which('nucypher-stdio-receiver')


This is neat.

tuxxy · 2019-11-14T18:07:12Z

nucypher/cli/characters/alice.py

+
 @click.command()
 @click.argument('action')
+@click.option('--options', help="Export JSON type schema", is_flag=True)


The name of this option and the help don't really help me understand either here.

tuxxy · 2019-11-14T18:07:26Z

nucypher/cli/characters/enrico.py


 @click.command()
 @click.argument('action')
+@click.option('--options', help="Export JSON type schema", is_flag=True)


Same critique here, too.

KPrasch · 2019-12-03T22:13:18Z

Continuing the above dialog - How do we want to proceed with this PR?

michwill · 2019-12-03T22:17:24Z

There are some conflicts but... Doesn't seem to be breaking anything, so why not merge if those are fixed?

vepkenez · 2019-12-04T00:37:52Z

I think this PR will need a bit of work to adapt it to some of the CLI changes of late, but after that it will work better and will cover more functionality than it originally did when this was opened.

vepkenez force-pushed the connect-native-demo-cleaned branch from 7eeee6e to 964487a Compare September 5, 2019 16:53

jMyles added the Bob 👨‍💼 Effects the "Bob" development area label Sep 9, 2019

KPrasch self-requested a review September 11, 2019 16:20

jMyles changed the base branch from master to birdcage September 14, 2019 00:41

jMyles force-pushed the birdcage branch 2 times, most recently from bc41fe0 to a327baa Compare September 15, 2019 20:40

jMyles force-pushed the birdcage branch from a327baa to 12fb9f6 Compare September 21, 2019 02:15

vepkenez force-pushed the connect-native-demo-cleaned branch from b7d2996 to c16150d Compare October 3, 2019 00:21

vepkenez changed the base branch from birdcage to master October 3, 2019 00:35

vepkenez changed the title ~~NuCypher ConnectNative Firefox Extension~~ [WIP] NuCypher ConnectNative Firefox Extension Oct 4, 2019

KPrasch and others added 5 commits October 6, 2019 19:50

adds character options specifications

0e3fcf8

Gives Alice + Bob JSON schema CLI commands

37cc4df

adds connectnative stdio interface

5215846

adds firefox install script/README

92077ca

added startup status check, error messages, README

ac77840

test for options cli consistent with spec

8a22a68

vepkenez force-pushed the connect-native-demo-cleaned branch from 64a1dd8 to 8a22a68 Compare October 6, 2019 23:50

vepkenez mentioned this pull request Oct 22, 2019

SuperMarioBox example demo #1301

Merged

vepkenez changed the base branch from master to birdcage October 23, 2019 13:59

vepkenez and others added 3 commits October 23, 2019 12:08

pause_console_logging_while we run this test

16e9929

use discover.nucypher.network as a teacher

2719a06

CI: run install_egg_info before pip install to get rid of ContextualV…

db48bac

…ersionConflict pypa/pip#4537 (comment)

vepkenez changed the title ~~[WIP] NuCypher ConnectNative Firefox Extension~~ NuCypher ConnectNative Firefox Extension Nov 6, 2019

tuxxy reviewed Nov 14, 2019

View reviewed changes

KPrasch force-pushed the birdcage branch from e9191a1 to f593b74 Compare December 3, 2019 22:53

jMyles force-pushed the birdcage branch from 6580614 to 035de52 Compare December 15, 2019 07:07

KPrasch changed the title ~~NuCypher ConnectNative Firefox Extension~~ [WIP] NuCypher ConnectNative Firefox Extension Jan 6, 2020

vepkenez mentioned this pull request Jan 8, 2020

Refactor Specifications/Serializers #1555

Merged

jMyles force-pushed the birdcage branch 5 times, most recently from 19e2bf8 to c7ee2e1 Compare January 16, 2020 00:48

jMyles force-pushed the birdcage branch from d78f42e to d8aebfd Compare January 18, 2020 11:56

jMyles force-pushed the birdcage branch 3 times, most recently from b6e6fce to 5587b37 Compare February 2, 2020 11:23

jMyles force-pushed the birdcage branch 2 times, most recently from 1fc797c to c525ba0 Compare February 8, 2020 12:27

vepkenez closed this Feb 10, 2020

Conversation

vepkenez commented Sep 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tuxxy commented Sep 18, 2019

Uh oh!

michwill commented Sep 28, 2019

Uh oh!

michwill commented Sep 29, 2019

Uh oh!

michwill commented Sep 29, 2019

Uh oh!

KPrasch commented Oct 1, 2019

Uh oh!

KPrasch commented Oct 2, 2019

Uh oh!

michwill commented Oct 2, 2019

Uh oh!

vepkenez commented Oct 3, 2019

Uh oh!

vepkenez commented Oct 3, 2019

Uh oh!

michwill commented Oct 3, 2019

Uh oh!

vepkenez commented Oct 3, 2019

Uh oh!

michwill commented Oct 3, 2019

Uh oh!

vepkenez commented Oct 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vepkenez commented Oct 4, 2019

Uh oh!

KPrasch commented Nov 14, 2019

Uh oh!

vepkenez commented Nov 14, 2019

Uh oh!

tuxxy Nov 14, 2019

Choose a reason for hiding this comment

Uh oh!

tuxxy Nov 14, 2019

Choose a reason for hiding this comment

Uh oh!

tuxxy Nov 14, 2019

Choose a reason for hiding this comment

Uh oh!

KPrasch commented Dec 3, 2019

Uh oh!

michwill commented Dec 3, 2019

Uh oh!

vepkenez commented Dec 4, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

vepkenez commented Sep 5, 2019 •

edited

Loading

codecov bot commented Sep 5, 2019 •

edited

Loading

vepkenez commented Oct 3, 2019 •

edited

Loading