Closed
Conversation
…ave the one in `main.py`
… USER_LOG_DIR, is created
…ng to NucypherClickConfig
Codecov Report
@@ Coverage Diff @@
## master #1079 +/- ##
==========================================
+ Coverage 83.38% 83.47% +0.09%
==========================================
Files 67 67
Lines 8770 8801 +31
==========================================
+ Hits 7313 7347 +34
+ Misses 1457 1454 -3
Continue to review full report at Codecov.
|
Contributor
Author
|
Closing in favor of reworked and rebased PR #1103 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to simplify CLI option processing (mostly the ones related to logging) and remove duplicate options, which will in turn pave way for fixing issue #1018
Note: this branch started as a fix for issue #1018, but got transformed into CLI option rearrangement. Perhaps the last commit should be a separate PR
Public API changes:
All options are now specified after commands. That is, if before one would call
after the PR the syntax would be
Cons:
clickphilosophy (see thisclickissue).config.pyrequired for this to work.Pros:
--help. That is, if before, in order to find out about--debug, one would have to callnucypher --helpin addition tonucypher alice --help, now justnucypher alice --helpwill be enough - all the options will be there.Added
--no-sentryoption to turn off Sentry logging.--debugnow just sets/unsets certain otherwise available CLI options (TODO: to be determined which ones exactly), acting as a shortcut.NUCYPHER_SENTRY_LOGSandNUCYPHER_FILE_LOGShave stricter requirements for their contents (whateverstrtoboolcan recognize)TODO:
--verbosesets the logging levelTODO: add an option to turn off banners
Internal changes:
GlobalLoggerclass manages all logging and observers.TODO: get rid of
emitmethods in random classes and use standard existing logging facilities?