Skip to content

Un tapita para la Alhambra Verde#1046

Merged
KPrasch merged 4 commits intonucypher:alhambra-verdefrom
cygnusv:tapa
Jun 6, 2019
Merged

Un tapita para la Alhambra Verde#1046
KPrasch merged 4 commits intonucypher:alhambra-verdefrom
cygnusv:tapa

Conversation

@cygnusv
Copy link
Member

@cygnusv cygnusv commented Jun 4, 2019

Missing renamings and other minor stuff

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #1046 into alhambra-verde will decrease coverage by 0.14%.
The diff coverage is 75%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           alhambra-verde    #1046      +/-   ##
==================================================
- Coverage           83.32%   83.17%   -0.15%     
==================================================
  Files                  67       67              
  Lines                8680     8680              
==================================================
- Hits                 7233     7220      -13     
- Misses               1447     1460      +13
Impacted Files Coverage Δ
nucypher/blockchain/eth/actors.py 77.21% <0%> (ø) ⬆️
nucypher/utilities/sandbox/blockchain.py 88.65% <0%> (ø) ⬆️
nucypher/blockchain/eth/deployers.py 91.09% <100%> (ø) ⬆️
nucypher/utilities/sandbox/constants.py 98.11% <100%> (ø) ⬆️
nucypher/cli/config.py 90.21% <100%> (ø) ⬆️
nucypher/network/nodes.py 82.08% <0%> (-1.93%) ⬇️
nucypher/blockchain/eth/interfaces.py 69.88% <0%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f0972f...cd26c57. Read the comment docs.

@KPrasch KPrasch force-pushed the alhambra-verde branch 2 times, most recently from e4267f3 to 5f0972f Compare June 5, 2019 16:35
@cygnusv cygnusv changed the title [WIP] La alhambra verde viene con tapa Un tapita para la Alhambra Verde Jun 6, 2019
@cygnusv cygnusv marked this pull request as ready for review June 6, 2019 14:06
@KPrasch
Copy link
Member

KPrasch commented Jun 6, 2019

I searched the codebase for remaining occurrences of "miner" - Things look in order here.

@KPrasch KPrasch merged commit 8bd0459 into nucypher:alhambra-verde Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants