Skip to content

Disallow creating persistent character configurations in --dev mode#1017

Merged
KPrasch merged 1 commit intonucypher:masterfrom
fjarri:cli-no-init-for-dev-flag
May 29, 2019
Merged

Disallow creating persistent character configurations in --dev mode#1017
KPrasch merged 1 commit intonucypher:masterfrom
fjarri:cli-no-init-for-dev-flag

Conversation

@fjarri
Copy link
Contributor

@fjarri fjarri commented May 27, 2019

No description provided.

@fjarri fjarri added CLI This effects the nucypher CLI Configuration Node configuration labels May 27, 2019
@fjarri fjarri requested a review from KPrasch May 27, 2019 16:40
@codecov
Copy link

codecov bot commented May 27, 2019

Codecov Report

Merging #1017 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1017   +/-   ##
=======================================
  Coverage   84.98%   84.98%           
=======================================
  Files          65       65           
  Lines        7908     7908           
=======================================
  Hits         6721     6721           
  Misses       1187     1187
Impacted Files Coverage Δ
nucypher/cli/characters/alice.py 79.59% <0%> (ø) ⬆️
nucypher/cli/characters/ursula.py 75.26% <0%> (ø) ⬆️
nucypher/cli/characters/bob.py 72.15% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 020787d...aa71461. Read the comment docs.

@codecov
Copy link

codecov bot commented May 27, 2019

Codecov Report

Merging #1017 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
+ Coverage   84.98%   85.02%   +0.03%     
==========================================
  Files          65       65              
  Lines        7908     7908              
==========================================
+ Hits         6721     6724       +3     
+ Misses       1187     1184       -3
Impacted Files Coverage Δ
nucypher/cli/characters/alice.py 80.61% <100%> (+1.02%) ⬆️
nucypher/cli/characters/bob.py 73.41% <100%> (+1.26%) ⬆️
nucypher/cli/characters/ursula.py 75.8% <100%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 020787d...cbff090. Read the comment docs.

@fjarri fjarri force-pushed the cli-no-init-for-dev-flag branch from aa71461 to cbff090 Compare May 28, 2019 19:02
@fjarri fjarri marked this pull request as ready for review May 28, 2019 19:21
@KPrasch KPrasch merged commit 04e39e5 into nucypher:master May 29, 2019
@fjarri fjarri deleted the cli-no-init-for-dev-flag branch May 30, 2019 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLI This effects the nucypher CLI Configuration Node configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants