Skip to content

Abstract/Cleanup BlockChainInterface#1016

Merged
KPrasch merged 8 commits intonucypher:hawksbeardfrom
vepkenez:clean-merge-bca
May 31, 2019
Merged

Abstract/Cleanup BlockChainInterface#1016
KPrasch merged 8 commits intonucypher:hawksbeardfrom
vepkenez:clean-merge-bca

Conversation

@vepkenez
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #1016 into hawksbeard will decrease coverage by 5.72%.
The diff coverage is 58.63%.

Impacted file tree graph

@@              Coverage Diff               @@
##           hawksbeard    #1016      +/-   ##
==============================================
- Coverage        81.1%   75.38%   -5.73%     
==============================================
  Files              67       67              
  Lines            8560     8629      +69     
==============================================
- Hits             6943     6505     -438     
- Misses           1617     2124     +507
Impacted Files Coverage Δ
nucypher/cli/deploy.py 0% <0%> (-71.04%) ⬇️
nucypher/blockchain/eth/chains.py 60% <27.27%> (+5.76%) ⬆️
nucypher/blockchain/eth/interfaces.py 66.42% <58.65%> (-0.95%) ⬇️
nucypher/blockchain/eth/clients.py 47.27% <59.48%> (+11.75%) ⬆️
nucypher/blockchain/eth/actors.py 67.84% <66.66%> (-9%) ⬇️
nucypher/blockchain/eth/registry.py 60.88% <81.81%> (-6.62%) ⬇️
nucypher/characters/chaotic.py 25% <0%> (-50%) ⬇️
nucypher/cli/characters/felix.py 32% <0%> (-37%) ⬇️
nucypher/cli/characters/alice.py 35.41% <0%> (-28.13%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52420e0...e459283. Read the comment docs.

@KPrasch
Copy link
Member

KPrasch commented May 31, 2019

Follow-up fixes incoming in #1031

@KPrasch KPrasch merged commit 60ed5de into nucypher:hawksbeard May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants