Skip to content

Remove maximum stake duration validation#1011

Merged
KPrasch merged 2 commits intonucypher:hawksbeardfrom
KPrasch:retoken
May 27, 2019
Merged

Remove maximum stake duration validation#1011
KPrasch merged 2 commits intonucypher:hawksbeardfrom
KPrasch:retoken

Conversation

@KPrasch
Copy link
Member

@KPrasch KPrasch commented May 26, 2019

Fixes #998

@KPrasch KPrasch requested a review from tuxxy May 26, 2019 19:28
@codecov
Copy link

codecov bot commented May 27, 2019

Codecov Report

Merging #1011 into hawksbeard will increase coverage by 6.07%.
The diff coverage is 64.93%.

Impacted file tree graph

@@              Coverage Diff              @@
##           hawksbeard   #1011      +/-   ##
=============================================
+ Coverage       75.03%   81.1%   +6.07%     
=============================================
  Files              67      67              
  Lines            8560    8560              
=============================================
+ Hits             6423    6943     +520     
+ Misses           2137    1617     -520
Impacted Files Coverage Δ
nucypher/blockchain/eth/token.py 89.78% <ø> (ø) ⬆️
nucypher/cli/painting.py 49.21% <ø> (-26.57%) ⬇️
nucypher/cli/characters/moe.py 60.71% <0%> (ø) ⬆️
nucypher/characters/lawful.py 88.23% <100%> (+0.94%) ⬆️
nucypher/crypto/powers.py 95.08% <100%> (ø) ⬆️
nucypher/cli/characters/alice.py 63.54% <100%> (+28.12%) ⬆️
nucypher/blockchain/eth/agents.py 89.66% <100%> (ø) ⬆️
nucypher/utilities/sandbox/constants.py 98.11% <100%> (ø) ⬆️
nucypher/network/server.py 87.9% <100%> (+1.86%) ⬆️
nucypher/network/teachers.py 100% <100%> (ø) ⬆️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d11f497...b334264. Read the comment docs.

@KPrasch
Copy link
Member Author

KPrasch commented May 27, 2019

Merging with known Issue: https://circleci.com/gh/nucypher/nucypher/29271#tests/containers/5 described in #1014

@KPrasch KPrasch marked this pull request as ready for review May 27, 2019 16:29
@KPrasch KPrasch merged commit 52420e0 into nucypher:hawksbeard May 27, 2019
@KPrasch KPrasch deleted the retoken branch July 21, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant