-
Notifications
You must be signed in to change notification settings - Fork 277
Closed
Labels
Code Quality 🔧Pertaining to code quality improvementsPertaining to code quality improvementsStyle ✨Make it look nicerMake it look nicerwontfixNon-issue or no intent for changesNon-issue or no intent for changes
Description
Related to #2687 .
Full discussion here: #2687 (comment)
> Do you have a preference for consistency? If it's the namepacing that matters most to you perhaps we make a typing module per contract?
I think some sort of more direct association between the types defined and the contracts would make them more intuitive. Having them live in nucypher/types.py just seems vague; it could be a typing module per contract or even keeping it general like nucypher.blockchain.eth.types...?
@derekpierre derekpierre 2 days ago Member
^ BTW Doesn't have to be this PR - maybe the namespacing can be looked into as part of a separate PR.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Code Quality 🔧Pertaining to code quality improvementsPertaining to code quality improvementsStyle ✨Make it look nicerMake it look nicerwontfixNon-issue or no intent for changesNon-issue or no intent for changes