-
Notifications
You must be signed in to change notification settings - Fork 277
Closed
Labels
Code Quality 🔧Pertaining to code quality improvementsPertaining to code quality improvementsStyle ✨Make it look nicerMake it look nicer
Description
Currently, emitters are instantiated at the CLI level however sometimes context from deeper in the stack is needed. For example: interactively confirming transactions just in time, before signing and broadcasting.
Question: "Is it okay to use an embedded emitter?"
At the moment we just init emitters on-the-fly, However this can sometimes case issues where JSON RPC output is expected. (see https://github.com/nucypher/nucypher/blob/master/nucypher/blockchain/eth/actors.py#L1276).
Alternately, we can re-implement emitters as process local singletons.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Code Quality 🔧Pertaining to code quality improvementsPertaining to code quality improvementsStyle ✨Make it look nicerMake it look nicer