Skip to content

Reconsider Embedded Emitters #1754

@KPrasch

Description

@KPrasch

Currently, emitters are instantiated at the CLI level however sometimes context from deeper in the stack is needed. For example: interactively confirming transactions just in time, before signing and broadcasting.

Question: "Is it okay to use an embedded emitter?"
At the moment we just init emitters on-the-fly, However this can sometimes case issues where JSON RPC output is expected. (see https://github.com/nucypher/nucypher/blob/master/nucypher/blockchain/eth/actors.py#L1276).

Alternately, we can re-implement emitters as process local singletons.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Code Quality 🔧Pertaining to code quality improvementsStyle ✨Make it look nicer

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions