Merged
Conversation
8 tasks
HandoverTranscript, a.k.a. "The Baton", represents the message an incoming node produces to initiate a handover with an outgoing node. After the handover, the incoming node replaces the outgoing node in an existing cohort, securely obtaining a new blinded key share, but under the incoming node's private key.
Also, no need to pass the incoming public key, since it's already in the transcript
- Check that share index is in range - Check that outgoing pubkey is consistent - Check that resulting share is correct
derekpierre
approved these changes
May 27, 2025
| #[test_case(4, 4; "N is a power of 2, t=N")] | ||
| #[test_case(30, 16; "N is not a power of 2, t is 1 + 50%")] | ||
| #[test_case(30, 30; "N is not a power of 2, t=N")] | ||
| fn test_dkg_simple_tdec_handover(shares_num: u32, security_threshold: u32) { |
Member
There was a problem hiding this comment.
Great test - read like a story! 🔥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
This PR introduces the core cryptography for the handover process. In this process, an incoming and departing node interact in such a way that there's a secure and publicly verifiable handover of the private key share. The resulting aggregate transcript is equal to the original, except for the blinded share corresponding to the handover, which in turn contains the same private key share, encrypted now with the incoming validator key.
Issues fixed/closed:
Why it's needed:
Notes for reviewers:
The test in
ferveo/src/lib.rsshows a relatively high-level view of how the handover works, so I'd start from there, or at least focus on that. The core cryptographic components are added in the new ´HandoverTranscriptstruct in therefresh.rs` module.