feat(ui): notebook loading skeleton for daemon-owned doc population (#599)#611
Merged
feat(ui): notebook loading skeleton for daemon-owned doc population (#599)#611
Conversation
Replace the single CellSkeleton placeholder with three skeleton cells of varying heights (2.5rem, 5rem, 2rem) to better mimic a real notebook loading. Staggered animation delays (0/75/150ms) give a subtle wave effect on the pulse animation. The loading state infrastructure from #607 handles detection: - isLoading=true until bootstrap finds cells or first sync message - CellSkeleton shows when cells.length===0 && isLoading - Transition to real cells is automatic via useSyncExternalStore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #599.
Builds on #607 (external store +
awaitingInitialSyncRefloading detection).What changed
CellSkeletonnow renders three skeleton cells with varying heights instead of one, giving a more realistic "notebook is loading" appearance. StaggeredanimationDelayon the pulse creates a subtle wave effect.How loading works (from #607)
isLoadingstartstruebootstrap()fetches doc bytes from daemon viaGetDocBytesrequestisLoading = falseimmediatelyautomerge:from-daemonmessageNotebookViewContentshows<CellSkeleton />whencells.length === 0 && isLoadingFollow-ups
DaemonReadyPayload { cell_count }is emitted but not consumed yet — could size the skeleton to match the actual notebook