feat(notebook): show native error dialog for notebook load failures#574
Merged
feat(notebook): show native error dialog for notebook load failures#574
Conversation
Replace panic-on-error with user-friendly native error dialog using rfd. When notebook loading fails (invalid file, parsing errors, missing file), users now see a clear error message instead of a silent crash. This improves error transparency at the pre-window stage before React can render UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When notebook loading fails (invalid file, parsing errors, permission denied), the app now displays a native error dialog instead of silently crashing. Users see a clear message with the file path and error details.
Example
Before: App crashes silently, stderr shows "notebook app failed". Users probably don't see stderr.
After: Native macOS error dialog appears with "Cannot Open Notebook" and the specific error
Implementation
rfddependency for native dialogsmain.rsto catch errors before process exit.expect()panic with user-friendly error messagePR submitted by @rgbkrk's agent, Quill