feat(runtimed-wasm): expose typed metadata and runtime detection on WASM handle#568
Merged
feat(runtimed-wasm): expose typed metadata and runtime detection on WASM handle#568
Conversation
…ASM handle Phase 0 of the WASM metadata migration plan. WASM additions: - get_metadata_snapshot_json() — returns NotebookMetadataSnapshot as JSON - detect_runtime() — returns 'python', 'deno', or undefined These call through to the existing notebook-doc methods, making typed metadata reads available to the frontend without Tauri IPC. Also removes dead Tauri commands: get_deno_permissions, set_deno_permissions (zero frontend callers). WASM artifacts rebuilt with wasm-pack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 0 of the WASM metadata migration plan. Exposes typed metadata reads on the WASM
NotebookHandleso the frontend can read from its local Automerge doc instead of going through Tauri IPC.WASM API additions
These call through to the already-existing
NotebookDocmethods from thenotebook-docshared crate (#562, #566).Dead code removal
get_deno_permissions— zero frontend callersset_deno_permissions— zero frontend callersQA
WASM binary size: 1104KB → 1194KB (+90KB from pulling in
serde_jsonserialization for the metadata snapshot and the metadata module's types). Thenotebook-doccrate now includes the metadata types that were previously only inruntimed.Next: Phase 2 will migrate the read-only Tauri commands (
get_notebook_runtime,get_notebook_dependencies, etc.) to use these WASM methods instead ofinvoke().