refactor(notebook): remove dead NotebookState cell mutation methods#558
Merged
refactor(notebook): remove dead NotebookState cell mutation methods#558
Conversation
Remove 8 methods from NotebookState that have zero production callers since cell mutations moved to the WASM Automerge doc: - find_cell_index - update_cell_source - get_cell_source - add_cell - delete_cell - clear_cell_outputs - set_cell_execution_count - append_cell_output Also removes source_to_lines helper (only used by update_cell_source) and the unused Output import. Rewrites 3 remaining tests to construct nbformat cells directly instead of using the removed methods. -420 lines, 16 tests still passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continued cleanup after the Automerge migration (#553, #554).
Removes 8
NotebookStatemethods that have zero production callers — all cell mutations now go through the WASMNotebookHandle+ Automerge sync:find_cell_indexupdate_cell_sourceupdate_cell_sourceTauri command (removed in #554)get_cell_sourceadd_celladd_cellTauri command (removed in #554)delete_celldelete_cellTauri command (removed in #554)clear_cell_outputsset_cell_execution_countappend_cell_outputAlso removes
source_to_lineshelper and unusedOutputimport.3 tests that called removed methods were rewritten to construct nbformat cells directly. 16 notebook_state tests still passing.
−420 lines.