Skip to content

Migrate documentation validation from build.fsproj to Roslyn code generator#883

Merged
dtchepak merged 3 commits intonsubstitute:mainfrom
Romfos:doc1
Jun 9, 2025
Merged

Migrate documentation validation from build.fsproj to Roslyn code generator#883
dtchepak merged 3 commits intonsubstitute:mainfrom
Romfos:doc1

Conversation

@Romfos
Copy link
Copy Markdown
Contributor

@Romfos Romfos commented May 30, 2025

Changes:

  • Migrate documentation validation from build.fsproj to Roslyn code generator
  • Build system now is trivial
  • Update some test dependencies

Benefits:

  • Easy to run. You can run it directly from visual studio or via dotnet test as normal tests
  • Easy to debug. Just put a breakpoint as in normal c# code
  • Easy to support. No more f#. Easy to update dependencies and making changes
  • No complex logic with creating temporary test project and custom build logic. Now build is trivial

@Romfos Romfos mentioned this pull request May 30, 2025
26 tasks
@Romfos
Copy link
Copy Markdown
Contributor Author

Romfos commented May 30, 2025

blocked by: #882

@Romfos Romfos marked this pull request as ready for review May 30, 2025 13:22
@Romfos Romfos requested a review from dtchepak May 30, 2025 13:24
Copy link
Copy Markdown
Member

@dtchepak dtchepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more f#.

But I love f# 😭 😂

Other than that, this is a really nice change, thanks. ❤️

@Romfos
Copy link
Copy Markdown
Contributor Author

Romfos commented Jun 9, 2025

rebased. please review & merge if ready

@Romfos Romfos requested a review from dtchepak June 9, 2025 06:37
@dtchepak dtchepak merged commit bb94586 into nsubstitute:main Jun 9, 2025
8 checks passed
@Romfos Romfos deleted the doc1 branch June 9, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants