Skip to content

Castle.Core 5.2.1#870

Closed
304NotModified wants to merge 1 commit intonsubstitute:mainfrom
304NotModified:patch-1
Closed

Castle.Core 5.2.1#870
304NotModified wants to merge 1 commit intonsubstitute:mainfrom
304NotModified:patch-1

Conversation

@304NotModified
Copy link
Copy Markdown
Contributor

@304NotModified 304NotModified commented Mar 9, 2025 •
edited
Loading

Testing 5.2.x

castleproject/Core#662

See also remarks for NSubstitute at castleproject/Core#684

@304NotModified
Copy link
Copy Markdown
Contributor Author

304NotModified commented Mar 9, 2025 •
edited
Loading

It seems there are nullable changes in Caste Core we should handle here. See build errors.

Error: /home/runner/work/NSubstitute/NSubstitute/src/NSubstitute/Proxies/CastleDynamicProxy/ProxyIdInterceptor.cs(28,29): error CS8602: Dereference of a possibly null reference. [/home/runner/work/NSubstitute/NSubstitute/src/NSubstitute/NSubstitute.csproj::TargetFramework=net8.0]
Error: /home/runner/work/NSubstitute/NSubstitute/src/NSubstitute/Proxies/CastleDynamicProxy/CastleInvocationMapper.cs(12,13): error CS8602: Dereference of a possibly null reference. [/home/runner/work/NSubstitute/NSubstitute/src/NSubstitute/NSubstitute.csproj::TargetFramework=net8.0]
Error: /home/runner/work/NSubstitute/NSubstitute/src/NSubstitute/Proxies/CastleDynamicProxy/CastleInvocationMapper.cs(27,72): error CS8603: Possible null reference return. [/home/runner/work/NSubstitute/NSubstitute/src/NSubstitute/NSubstitute.csproj::TargetFramework=net8.0]
Error: /home/runner/work/NSubstitute/NSubstitute/src/NSubstitute/Proxies/CastleDynamicProxy/CastleDynamicProxyFactory.cs(128,26): error CS8604: Possible null reference argument for parameter 'target' in 'object ProxyGenerator.CreateInterfaceProxyWithTarget(Type interfaceToProxy, Type[]? additionalInterfacesToProxy, object target, ProxyGenerationOptions options, params IInterceptor[] interceptors)'. [/home/runner/work/NSubstitute/NSubstitute/src/NSubstitute/NSubstitute.csproj::TargetFramework=net8.0]

@304NotModified 304NotModified mentioned this pull request Mar 9, 2025
Open
@Romfos Romfos mentioned this pull request Jun 30, 2025
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@304NotModified