Feature: allow interception of any generic method call when using Arg.AnyType#855
Merged
dtchepak merged 1 commit intonsubstitute:mainfrom Mar 23, 2025
JMolenkamp:main
Merged
Feature: allow interception of any generic method call when using Arg.AnyType#855dtchepak merged 1 commit intonsubstitute:mainfrom JMolenkamp:main
dtchepak merged 1 commit intonsubstitute:mainfrom
JMolenkamp:main
Conversation
Member
|
Hi @JMolenkamp , Thanks a lot for this. Could you please add tests to this PR to demonstrate the change? |
Contributor
Author
|
Added some tests. The first two fail without the change. The last one does not build without the change. Maybe this PR needs to be split into two. Part of it is a fix for the first two tests, which should not fail, I think? |
Contributor
Author
dtchepak
reviewed
Mar 16, 2025
Member
dtchepak
left a comment
There was a problem hiding this comment.
Thanks for this!
Merged in dependent PR. I think needs a rebase now.
dtchepak
approved these changes
Mar 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow for interception of any call to a generic method, regardless of used generic argument.
Related to issue 854