Skip to content

Migrate from NUnit 3 to NUnit 4#783

Merged
dtchepak merged 2 commits intonsubstitute:mainfrom
Romfos:nunit4
May 1, 2024
Merged

Migrate from NUnit 3 to NUnit 4#783
dtchepak merged 2 commits intonsubstitute:mainfrom
Romfos:nunit4

Conversation

@Romfos
Copy link
Copy Markdown
Contributor

@Romfos Romfos commented Mar 4, 2024 •
edited
Loading

Changes:

  • Migrate to NUnit4
  • Update nuget packages for test projects

note: no changes in product, no need to release new nuget package

@Romfos Romfos changed the title Update to nunit4 Migrate from NUnit 3 to NUnit 4 Mar 4, 2024
alexandrnikitin
alexandrnikitin approved these changes Mar 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@alexandrnikitin alexandrnikitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you! @Romfos
I'm sorry, I stopped following .NET development. What is the general recommendation regarding NUnit.Framework.Legacy and ClassicAssert? Do we need to migrate them to the newer API?

tests/NSubstitute.Benchmarks/NSubstitute.Benchmarks.csproj

<ItemGroup>
<PackageReference Include="BenchmarkDotNet" Version="0.13.10" />
<PackageReference Include="BenchmarkDotNet" Version="0.13.12" />
Copy link
Copy Markdown
Member

@alexandrnikitin alexandrnikitin Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks unrelated to NUnit.

Copy link
Copy Markdown
Contributor Author

@Romfos Romfos Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this related to Update nuget packages for test projects

tests/NSubstitute.Acceptance.Specs/ReceivedCalls.cs
using NSubstitute.Exceptions;
using NSubstitute.ReceivedExtensions;
using NUnit.Framework;
using NUnit.Framework.Legacy;
Copy link
Copy Markdown
Member

@alexandrnikitin alexandrnikitin Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused?

Copy link
Copy Markdown
Contributor Author

@Romfos Romfos Mar 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is needed for StringAssert

@alexandrnikitin
Copy link
Copy Markdown
Member

alexandrnikitin commented Mar 4, 2024 •
edited
Loading

It looks like TestCodeFromDocs project needs to be updated too.

NSubstitute/build/build.fs

Lines 164 to 166 in e67780b

<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageReference Include="NUnit" Version="3.14.0" />
<PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />

@Romfos
Copy link
Copy Markdown
Contributor Author

Romfos commented Mar 4, 2024

It looks like TestCodeFromDocs project needs to be updated too.

NSubstitute/build/build.fs

Lines 164 to 166 in e67780b

<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageReference Include="NUnit" Version="3.14.0" />
<PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />

need to be checked after #776 merge

@Romfos
Copy link
Copy Markdown
Contributor Author

Romfos commented Mar 4, 2024

LGTM!

Thank you! @Romfos I'm sorry, I stopped following .NET development. What is the general recommendation regarding NUnit.Framework.Legacy and ClassicAssert? Do we need to migrate them to the newer API?

I was not able to find recommendations for now, but this looks like temporary solution for migration from v3 to v4.
I think that in long term it should be refactored

@dtchepak
Copy link
Copy Markdown
Member

dtchepak commented Apr 30, 2024

LGTM!

Thank you! @Romfos I'm sorry, I stopped following .NET development. What is the general recommendation regarding NUnit.Framework.Legacy and ClassicAssert? Do we need to migrate them to the newer API?

Seems should replace with Assert.That.

@304NotModified
Copy link
Copy Markdown
Contributor

304NotModified commented Apr 30, 2024

LGTM!
Thank you! @Romfos I'm sorry, I stopped following .NET development. What is the general recommendation regarding NUnit.Framework.Legacy and ClassicAssert? Do we need to migrate them to the newer API?

Seems should replace with Assert.That.

Indeed, but IMO that could be another PR and this one could be merged

@dtchepak dtchepak merged commit ef7a2d0 into nsubstitute:main May 1, 2024
@dtchepak
Copy link
Copy Markdown
Member

dtchepak commented May 1, 2024

Thanks for this @Romfos ! And thanks for the reviews @alexandrnikitin and @304NotModified 🙇

@Romfos Romfos deleted the nunit4 branch May 1, 2024 12:38
This was referenced Jul 25, 2025
Closed
Closed
Closed
This was referenced Aug 4, 2025
Closed
Open
Closed
This was referenced Aug 15, 2025
Merged
Open
Open
Open
This was referenced Aug 23, 2025
Closed
Merged
Open
This was referenced Sep 2, 2025
Merged
Closed
@dependabot dependabot bot mentioned this pull request Sep 13, 2025
Closed
This was referenced Dec 8, 2025
Closed
Closed
Closed
Closed
This was referenced Dec 24, 2025
Merged
Merged
This was referenced Jan 5, 2026
Closed
Merged
Closed
This was referenced Jan 12, 2026
Closed
Closed
Closed
Closed
This was referenced Jan 20, 2026
Open
Merged
Open
Merged
This was referenced Feb 6, 2026
Merged
Open
Closed
Merged
@dependabot dependabot bot mentioned this pull request Feb 17, 2026
Open
This was referenced Feb 25, 2026
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Mar 10, 2026
Merged
This was referenced Mar 25, 2026
Closed
Open
This was referenced Apr 1, 2026
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexandrnikitin alexandrnikitin alexandrnikitin approved these changes

@304NotModified 304NotModified 304NotModified approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Romfos @alexandrnikitin @dtchepak @304NotModified