added ILoggerTests to ensure NSubstitute can be used to test specific ILogger calls happened.#732
Merged
dtchepak merged 3 commits intonsubstitute:mainfrom Sep 3, 2023
zlangner:add-support-for-ilogger-extension-methods
Merged
added ILoggerTests to ensure NSubstitute can be used to test specific ILogger calls happened.#732dtchepak merged 3 commits intonsubstitute:mainfrom zlangner:add-support-for-ilogger-extension-methods
dtchepak merged 3 commits intonsubstitute:mainfrom
zlangner:add-support-for-ilogger-extension-methods
Conversation
…ic ILogger calls happened.
Member
Contributor
I don't think so but it's very good since this was the original use case so it's really nice to have this fixed and the test suite as well. |
Saibamen
reviewed
Aug 29, 2023
Saibamen
reviewed
Aug 29, 2023
formatting Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
formatting Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
dtchepak
approved these changes
Sep 3, 2023
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#634 talks about wanting to use NSubstitute to validate a call into
Microsoft.Extensions.Logging.ILogger. I have the same need and found that the newArg.AnyTypeis insufficient to solving this problem.So I've added a new test class that shows a number of scenarios using
LoggerExtensionsextension methods fromMicrosoft.Extensions.Logging.ILogger. The tests include:As you'll see, I had to change how
TypesAreAllEquivalentworks to handle theFunc<TState, Exception?, string>used by ILogger.