Add support for ReturnsNull calls for nullable value types#692
Merged
dtchepak merged 1 commit intonsubstitute:mainfrom Jul 10, 2022
Merged
Add support for ReturnsNull calls for nullable value types#692dtchepak merged 1 commit intonsubstitute:mainfrom
ReturnsNull calls for nullable value types#692dtchepak merged 1 commit intonsubstitute:mainfrom
Conversation
Member
|
Thanks @Stedoss ! |
Member
|
Released in 4.4.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, you are not able to
ReturnsNull()on nullable value types (eg.int?andGuid?), and when wrapped in tasks they will throw a nullref, such as:This PR should help fix this by extending the extension methods to handle nullable value types, along with wrapping them in
TaskandValueTasktypes when necessary.I have written unit tests such that it tests for nullability on the newly added functionality, please let me know if more thorough tests are needed.
Note:
ReturnsNull()will still throw a nullref if the value type inside of aTaskis NOT nullable.Thank you!