Skip to content

Add .ThrowsAsync() that will correctly mock exception on async methods#663

Merged
dtchepak merged 3 commits intonsubstitute:mainfrom
Socolin:throws-async
Feb 27, 2022
Merged

Add .ThrowsAsync() that will correctly mock exception on async methods#663
dtchepak merged 3 commits intonsubstitute:mainfrom
Socolin:throws-async

Conversation

@Socolin
Copy link
Copy Markdown
Contributor

@Socolin Socolin commented Aug 29, 2021

It should fix #609

@Socolin
Copy link
Copy Markdown
Contributor Author

Socolin commented Aug 29, 2021 •
edited
Loading

I'm unsure about some part, I had to add #if for net4.5 (no Task.FromException)
Also netstandard < 2.1 and netcoreapp < 2.1 does not have ValueTask

I did use some reflection to find the appropriate Task.FromException / Task.FromException<T> when using .ThrowsAsync<TException>() on a Task<TResult> to avoid to force the users to specify the return type each time (.ThrowsAsync<TResult, TException>()) but I'm not sure about this part. Since I was not able to do the same for ValueTask<T>, if you have any preference on this let me know I can change it.

@dtchepak
Copy link
Copy Markdown
Member

dtchepak commented Sep 12, 2021

Thanks a lot for this! It looks great!

I'm playing around with some ideas for reducing the scope of the #if switches. I'll get back to you.

@Socolin
Copy link
Copy Markdown
Contributor Author

Socolin commented Jan 31, 2022

I've updated the PR with your changes

@dtchepak dtchepak merged commit a6ce8c1 into nsubstitute:main Feb 27, 2022
@dtchepak
Copy link
Copy Markdown
Member

dtchepak commented Feb 27, 2022

Thanks @Socolin ! Sorry for the delay in merging and my incomplete PR 🤦

@Socolin
Copy link
Copy Markdown
Contributor Author

Socolin commented Feb 27, 2022

Thanks @Socolin ! Sorry for the delay in merging and my incomplete PR facepalm

That's great news :) Thanks to have taken time for this.

@dependabot dependabot bot mentioned this pull request Aug 18, 2025
Open
@dependabot dependabot bot mentioned this pull request Dec 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mock throwing an exception for async methods

2 participants

@Socolin @dtchepak