Slightly refactor code to make it look fresh#639
Merged
zvirja merged 3 commits intonsubstitute:masterfrom Dec 29, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I did a bit of polishing to make our code look nicer, cleaner and easier to read and maintain. Here is an approximate list of changes:
ArgumentNullExceptionchecks from the internal parts of the code (i.e. mostlyNSubstitute.Core), as now we have nullability in place to verify code is right. Code was not covered entirely anyway, so should not be an issue. If we have advanced clients who are using advanced API and pushnullvalues - well, either enable nullability or just be a nice person then 😊SubstituteExtensionsinto multiple partial classes, so that it's easier to navigate and maintain. Before it was just one huge junk with everything there.There might other changes apart from the mentioned. Please review them if you don't like particular changes, so we could discuss those. Also I could completely revert/descope the individual commits if you would like to review/discuss those separately!
Thank you for your time!