Skip to content

DOC: Mix fixes.#2

Closed
Carreau wants to merge 2 commits into
nstarman:xref-docsfrom
Carreau:xref-docs
Closed

DOC: Mix fixes.#2
Carreau wants to merge 2 commits into
nstarman:xref-docsfrom
Carreau:xref-docs

Conversation

@Carreau

@Carreau Carreau commented Apr 17, 2021

Copy link
Copy Markdown

Attempt to run velin on astropy#11118

nstarman and others added 2 commits April 16, 2021 18:33
Signed-off-by: Nathaniel Starkman (@nstarman) <nstarkman@protonmail.com>
Attempt to run velin on astropy#11118
Comment on lines +499 to +500

normalization_zero_tol : float, optional

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
normalization_zero_tol : float, optional
normalization_zero_tol : float, optional

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Astropy 👋 and congratulations on your first pull request! 🎉

A project member will respond to you as soon as possible; in the meantime, please have a look over the Checklist for Contributed Code and make sure you've addressed as many of the questions there as possible.

If you feel that this pull request has not been responded to in a timely manner, please leave a comment mentioning our software support engineer @embray, or send a message directly to the development mailing list. If the issue is urgent or sensitive in nature (e.g., a security vulnerability) please send an e-mail directly to the private e-mail feedback@astropy.org.

@Carreau

Carreau commented Apr 17, 2021

Copy link
Copy Markdown
Author

There are many more whitespace related changes if you run

$ pip install velin
$ velin astropy --write --no-fail # maybe with --compact option depending on your whitespace preferences.

I've picked a couple interesting changes with git add -p after that.

It does fail in a couple of places where the numpydoc parsing is incorrect and that might need hand-fixing.

@Carreau Carreau mentioned this pull request Apr 17, 2021
24 tasks
@nstarman nstarman force-pushed the xref-docs branch 2 times, most recently from a69b0ca to e06a2b5 Compare April 18, 2021 00:26
@Carreau Carreau closed this Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants