Skip to content

sn/shard: clean up container data if it is unpaid#3871

Merged
roman-khimov merged 3 commits intomasterfrom
feat/drop-unpaid-containers
Mar 11, 2026
Merged

sn/shard: clean up container data if it is unpaid#3871
roman-khimov merged 3 commits intomasterfrom
feat/drop-unpaid-containers

Conversation

@carpawell
Copy link
Member

@carpawell carpawell commented Mar 10, 2026

Not only a warning, but a full cleanup. Refs #3650. Closes #3691.

@carpawell carpawell self-assigned this Mar 10, 2026
@carpawell
Copy link
Member Author

carpawell commented Mar 10, 2026 •
edited
Loading

For information: no unpaid ones in mainnet, 5 in testnet:

9iVfUg8aDHKjPC4LhQXEkVUM4HDkR7UCXYLs8NQwYfSG
9NimkSr5MxjLgQJEzoNFSaU3vHhSuLVKZvZRRRjbXbQ9
7WK6gLcj4jfkCJg8y8tQZhop9EHhJ76CyjkyECSZHbQz
4zdTinotoeuzAV2UXDs5ZafDkMarA4tyrchFHJ4YWDXA
2tptVcqJsRE4ZgwAs83hz8bN9cTeKcRNQSne5WWhACyR

@carpawell carpawell force-pushed the feat/drop-unpaid-containers branch from 5b4e4b3 to d89089e Compare March 10, 2026 13:55
@codecov
Copy link

codecov bot commented Mar 10, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.05%. Comparing base (7bdce47) to head (921f1c9).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cmd/neofs-node/container.go 0.00% 6 Missing ⚠️
pkg/local_object_storage/shard/gc.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3871   +/-   ##
=======================================
  Coverage   26.05%   26.05%           
=======================================
  Files         675      675           
  Lines       43589    43603   +14     
=======================================
+ Hits        11356    11360    +4     
- Misses      31174    31182    +8     
- Partials     1059     1061    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

roman-khimov
roman-khimov reviewed Mar 10, 2026
View reviewed changes
@carpawell carpawell requested a review from roman-khimov March 11, 2026 15:47
@carpawell
sn/shard: clean up container data if it is unpaid
58697c4 
Not only a warning, but a full cleanup. Refs #3650. Closes #3691.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
sn/shard_test: drop commented out test added by mistake
dc89180 
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
sn/shard: do not check containers payment status if no payment system…
921f1c9 
… enabled

Refs #3650.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell force-pushed the feat/drop-unpaid-containers branch from ef1b819 to 921f1c9 Compare March 11, 2026 15:48
@roman-khimov roman-khimov merged commit 6e853bb into master Mar 11, 2026
22 checks passed
@roman-khimov roman-khimov deleted the feat/drop-unpaid-containers branch March 11, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

@End-rey End-rey Awaiting requested review from End-rey End-rey is a code owner

Assignees

@carpawell carpawell

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop containers when unpaid

2 participants

@carpawell @roman-khimov