Drop GC mark for non-existent objects#3820
Merged
roman-khimov merged 3 commits intomasterfrom Feb 17, 2026
Merged
Conversation
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Marks can be added for objects that we don't have by GC handlers, in that case having a mark for some time has some benefits (prevents PUTs), however it should eventually be deleted. Non-physical check prevented that from happening leading to seemingly stuck objects in GC (iterating over the same set over and over again). Signed-off-by: Roman Khimov <roman@nspcc.ru>
c161f01 to
65a6ad8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3820 +/- ##
==========================================
+ Coverage 25.52% 25.53% +0.01%
==========================================
Files 669 669
Lines 42938 42940 +2
==========================================
+ Hits 10959 10966 +7
+ Misses 30974 30970 -4
+ Partials 1005 1004 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Being more specific is always better, allows to avoid some reflection code in zap itself. Also reveals that the only user of stringified AddressField() was write cache and passing oid.Address is easier for it as well. Signed-off-by: Roman Khimov <roman@nspcc.ru>
65a6ad8 to
ff30fb8
Compare
carpawell
approved these changes
Feb 17, 2026
End-rey
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.