Skip to content

morph: make client retry if fallback transaction was accepted#3798

Merged
roman-khimov merged 1 commit intomasterfrom
feat/container-removal-retries
Feb 9, 2026
Merged

morph: make client retry if fallback transaction was accepted#3798
roman-khimov merged 1 commit intomasterfrom
feat/container-removal-retries

Conversation

@carpawell
Copy link
Member

If complex notary invocation flow failed, retry transaction sending the same way it is done for ErrMempoolCapReached problems. Contract storages (and, therefore, GAS payments) may change b/w SN's test invocations and real transaction acceptance tries, and it is normal. In particular, it fixes #3739.

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.54%. Comparing base (bae8501) to head (f6b2e02).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/morph/client/static.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3798   +/-   ##
=======================================
  Coverage   25.53%   25.54%           
=======================================
  Files         661      661           
  Lines       42647    42648    +1     
=======================================
+ Hits        10892    10894    +2     
  Misses      30752    30752           
+ Partials     1003     1002    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@carpawell carpawell force-pushed the feat/container-removal-retries branch from 9572ea8 to a2d3310 Compare February 4, 2026 08:36
If complex notary invocation flow failed, retry transaction sending the same way
it is done for `ErrMempoolCapReached` problems. Contract storages (and,
therefore, GAS payments) may change b/w SN's test invocations and real
transaction acceptance tries, and it is normal. In particular, it fixes #3739.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@roman-khimov roman-khimov merged commit b76b366 into master Feb 9, 2026
17 of 22 checks passed
@roman-khimov roman-khimov deleted the feat/container-removal-retries branch February 9, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Container can't be removed because of insufficient GAS

2 participants