Merged
Conversation
976c1fe to
ef56c66
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3789 +/- ##
==========================================
- Coverage 25.70% 25.67% -0.03%
==========================================
Files 660 660
Lines 42167 42177 +10
==========================================
- Hits 10837 10828 -9
- Misses 30348 30364 +16
- Partials 982 985 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ef56c66 to
fa5fdd1
Compare
c0b85cb to
e0bdadd
Compare
e0bdadd to
ff0022a
Compare
roman-khimov
approved these changes
Jan 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes container ID handling by passing container IDs as parameters instead of recomputing them from marshalled container data. This is crucial for supporting "mutable containers" where container attributes can be modified while the ID remains constant.
Changes:
- Modified the
IsMineWithMetaandisContainerMinefunctions to accept container ID as a parameter instead of computing it from marshalled data - Updated CLI commands to return and reuse container IDs where available
- Enhanced ADM
fschain dump-containersandrestore-containerscommands to serialize/deserialize container IDs in JSON format
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/services/meta/meta.go | Updated IsMineWithMeta interface to accept container ID parameter |
| pkg/services/meta/notifications.go | Updated call to IsMineWithMeta to pass container ID |
| pkg/services/meta/notifications_test.go | Updated test mock to match new interface signature |
| cmd/neofs-node/meta.go | Updated IsMineWithMeta and isMineWithMeta implementations to accept container ID; modified isContainerMine to accept ID instead of computing it |
| cmd/neofs-node/container.go | Updated call to isContainerMine to pass container ID |
| cmd/neofs-cli/modules/container/get.go | Modified getContainer to return container ID; updated prettyPrintContainer to accept ID parameter |
| cmd/neofs-cli/modules/container/nodes.go | Updated to use container ID from getContainer with fallback computation |
| cmd/neofs-adm/internal/modules/fschain/container.go | Added ID field to Container struct; implemented ID serialization in dump and deserialization in restore commands |
| CHANGELOG.md | Documented new features for ADM fschain commands |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.