Fix error handling in removeNode notary request#3786
Merged
cthulhu-rider merged 1 commit intomasterfrom Jan 26, 2026
Merged
Conversation
Previously, errors from `RequestNotary` in case of `removeNode` were not propagated because a local `err` variable was shadowing the function-scoped error. Now using the function-scoped `err` variable to ensure errors are properly returned to the caller. Closes #3738. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3786 +/- ##
==========================================
- Coverage 25.68% 25.66% -0.02%
==========================================
Files 660 660
Lines 42203 42204 +1
==========================================
- Hits 10838 10832 -6
- Misses 30383 30389 +6
- Partials 982 983 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roman-khimov
approved these changes
Jan 26, 2026
Member
roman-khimov
left a comment
There was a problem hiding this comment.
Wow, took me some time to figure out why it's correct now. I thought it's something more systematic, but looks like only a single call is affected.
cthulhu-rider
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3738.