Skip to content

Unsigned container attribute responses#3784

Merged
cthulhu-rider merged 2 commits intomasterfrom
container-attribute-signatures
Jan 28, 2026
Merged

Unsigned container attribute responses#3784
cthulhu-rider merged 2 commits intomasterfrom
container-attribute-signatures

Conversation

@cthulhu-rider
Copy link
Contributor

No description provided.

@cthulhu-rider cthulhu-rider force-pushed the container-attribute-signatures branch from eb7c69f to dff38e4 Compare January 26, 2026 11:57
@cthulhu-rider cthulhu-rider changed the title Container attribute signatures Unsigned container attribute responses Jan 26, 2026
@cthulhu-rider cthulhu-rider marked this pull request as ready for review January 26, 2026 11:58
@cthulhu-rider cthulhu-rider force-pushed the container-attribute-signatures branch from dff38e4 to efa7960 Compare January 28, 2026 09:11
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.69%. Comparing base (c3e62dd) to head (1ef57cc).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
pkg/services/container/server.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3784      +/-   ##
==========================================
+ Coverage   25.67%   25.69%   +0.01%     
==========================================
  Files         660      660              
  Lines       42176    42153      -23     
==========================================
  Hits        10830    10830              
+ Misses      30362    30339      -23     
  Partials      984      984              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it say that it follows smth unmerged in another repo?

Follow nspcc-dev/neofs-sdk-go#772.

Refs #3396.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
This is going to be resolved within #2744. For now, it's better to just
unify.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider cthulhu-rider force-pushed the container-attribute-signatures branch from efa7960 to 1ef57cc Compare January 28, 2026 10:16
@cthulhu-rider
Copy link
Contributor Author

Why does it say that it follows smth unmerged in another repo?

fixed

@cthulhu-rider cthulhu-rider merged commit 1bfccec into master Jan 28, 2026
15 of 16 checks passed
@cthulhu-rider cthulhu-rider deleted the container-attribute-signatures branch January 28, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants