Merged
Conversation
80e0eee to
056f478
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3754 +/- ##
==========================================
- Coverage 25.86% 25.84% -0.03%
==========================================
Files 660 660
Lines 42213 42318 +105
==========================================
+ Hits 10920 10938 +18
- Misses 30290 30377 +87
Partials 1003 1003 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
056f478 to
356aba6
Compare
356aba6 to
c93e105
Compare
c93e105 to
d024500
Compare
Make server to check last size-split part when linker is unavailable. If this is the case, object or its payload range is restored from split chain. Closes #3736. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Unlike ResolveECPart(), the only caller of ResolveECPartWithPayloadLen() is unable to switch execution to linker. This makes the method to return error on LINK object encounter. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Refactoring purpose to keep in sync with last size-split child case. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
d024500 to
a007eaf
Compare
…n()` Previously, method returned 404 error if size-split object was requested. Although this is actually a failure (size-split roots are not erasure-coded), this error caused handling all shards in `StorageEngine.GetECPartRange()` instead of abort. This makes metabase to return split error in described case, and storage engine to abort on it. As bonus, the method is in sync with `ResolveECPart()` now. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
a007eaf to
2151aea
Compare
carpawell
approved these changes
Dec 26, 2025
roman-khimov
approved these changes
Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@evgeniiz321 try this pls