Skip to content

Slight metabase refactoring#3746

Merged
roman-khimov merged 6 commits intomasterfrom
meta-refactoring
Dec 19, 2025
Merged

Slight metabase refactoring#3746
roman-khimov merged 6 commits intomasterfrom
meta-refactoring

Conversation

@roman-khimov
Copy link
Member

@roman-khimov roman-khimov commented Dec 19, 2025 •
edited
Loading

No functional changes.

@roman-khimov
metabase: drop some dead code from put
08c873c 
Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov
*: use zap.Error() where appropriate
8afca56 
Follow 6398584 for more specific cases.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov
metabase: drop unused FilterExpired method
4051a75 
Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov
metabase: drop useless ExpiredObject type
329af34 
Deobfuscate code, optimize allocations.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov
metabase: reuse getObjAttribute in resolveECPartWithPayloadLenTx
abe1b0a 
Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov
metabase: don't pass bucket around where a cursor is sufficient
fad460a 
Signed-off-by: Roman Khimov <roman@nspcc.ru>
@codecov
Copy link

codecov bot commented Dec 19, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.51%. Comparing base (cf8889f) to head (fad460a).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
cmd/neofs-ir/main.go 0.00% 1 Missing ⚠️
cmd/neofs-node/main.go 0.00% 1 Missing ⚠️
pkg/local_object_storage/shard/control.go 50.00% 1 Missing ⚠️
...services/reputation/eigentrust/controller/calls.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3746      +/-   ##
==========================================
- Coverage   26.56%   26.51%   -0.06%     
==========================================
  Files         655      655              
  Lines       41505    41401     -104     
==========================================
- Hits        11027    10976      -51     
+ Misses      29470    29419      -51     
+ Partials     1008     1006       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roman-khimov roman-khimov merged commit f3dd8e3 into master Dec 19, 2025
21 of 22 checks passed
@roman-khimov roman-khimov deleted the meta-refactoring branch December 19, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@End-rey End-rey End-rey approved these changes

@carpawell carpawell Awaiting requested review from carpawell carpawell is a code owner

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roman-khimov @End-rey